Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove terminal white spaces when extracting text from annotation appearances #17487

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

calixteman
Copy link
Contributor

@Snuffleupagus
Copy link
Collaborator

In that case, should we also trim each array-entry here as well?

this.data.textContent = this._contents.str.split(/\r\n?|\n/);

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2ffd46d1b5922cb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a31cbe00fd4b823/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2ffd46d1b5922cb/output.txt

Total script time: 24.42 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 20
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/2ffd46d1b5922cb/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/a31cbe00fd4b823/output.txt

Total script time: 40.62 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 25

Image differences available at: http://54.193.163.58:8877/a31cbe00fd4b823/reftest-analyzer.html#web=eq.log

Snuffleupagus

This comment was marked as duplicate.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit 903af4e into mozilla:master Jan 10, 2024
9 checks passed
@calixteman calixteman deleted the fix_final_spaces branch January 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants